feat: support for api routes #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
lagoon-api-routes
branch
from
4eeea19 to
93a25c2
Compare
4 tasks
shreddedbacon
force-pushed
the
lagoon-api-routes
branch
from
93a25c2 to
b866aab
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive route management features for the Lagoon build-deploy tool, introducing API-defined routes, route source tracking, and automated cleanup of removed routes. The implementation adds support for distinguishing between routes from different sources (API, YAML, autogenerated) and includes logic for automatic cleanup when routes are managed via the API.
- Adds route source tracking via
route.lagoon.sh/sourcelabel to distinguish between API, YAML, and autogenerated routes - Implements API-managed route cleanup functionality that automatically removes routes not defined in API or .lagoon.yml
- Introduces support for primary route designation and active/standby route types from the API
Reviewed Changes
Copilot reviewed 95 out of 95 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| legacy/build-deploy-docker-compose.sh | Adds internalSystemEnvVarCheck function and implements conditional route cleanup logic based on API route management |
| internal/lagoon/routes.go | Adds Source, Primary, and Type fields to RouteV2 with custom UnmarshalJSON to handle API/YAML field name differences |
| internal/generator/ingress.go | Updates route generation to support API routes via LAGOON_API_ROUTES variable and primary route selection logic |
| internal/templating/templates_ingress.go | Adds route source label to ingress templates based on route origin |
| internal/generator/generator.go | Implements autogenerated route configuration from API via LAGOON_API_AUTOGENERATED_CONFIG |
| Test files (multiple) | Updates test expectations with new route source labels and adds test coverage for API-defined routes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Looks good from a code review perspective, withholding full review for related PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build support for uselagoon/lagoon#3990